-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read parquet example in parquet/arrow home #2730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
parquet/src/arrow/mod.rs
Outdated
//! # let ids = Int32Array::from(vec![1, 2, 3, 4]); | ||
//! # let schema = Arc::new(Schema::new(vec![ | ||
//! # Field::new("id", DataType::Int32, false), | ||
//! # Field::new("id", DataType::Int32, false), | ||
//! # ])); | ||
//! # | ||
//! # // Write to a memory buffer (can also write to a File) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment isn't actually correct, although I appreciate it was incorrect before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, I didn't realize. I just removed it, I don't think it adds much value to say we're writing to the file here. But let me know if you've got a better idea.
Benchmark runs are scheduled for baseline = 5f441ee and contender = a7a9329. a7a9329 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
None
Rationale for this change
The example in https://docs.rs/parquet/latest/parquet/arrow/index.html#example-of-reading-parquet-file-into-arrow-record-batch is using a deprecated API.
What changes are included in this PR?
A different example using the recommended API. The example is simpler than the original one, but I don't fully understand what the original example was trying to show. Feedback on how to extend/improve the example I wrote very welcome.
Are there any user-facing changes?
Only to the docs